Closed Morban15 closed 4 years ago
checking this out now! thanks!
I feel that the menu needs to appear above the logo. It's much more standard to have navigation at the top.
What do you think?
It would be nice to use the official font for the title MACILE Newsletter
I feel that the menu needs to appear above the logo. It's much more standard to have navigation at the top.
Current Design
Proposal
What do you think?
I was planning to do it. I agree.
It would be nice to use the official font for the title
MACILE Newsletter
I used
.menu {
font-family: 'Trajan Pro Regular', 'Times New Roman', serif;
}
Should I use Trajan Pro Bold
instead?
Should I use
Trajan Pro Bold
instead?
Ah, sorry, I did not inspect it. Yeah, try bold and try a bit of letter-spacing
.
@misscs sturdy-arm.surge.sh
I am sorry for the last minute structure changes to the header. There are many ways to do things and I try to avoid making too many personal preference changes because we all have our own styles. It wasn't until I was deeply examining the structure did I start to feel that we could improve the code structurally and make it a bit easier to understand how everything was laid out.
Hmm...I am not sure why that happened without looking at the code. You may need a position relative on <nav>
. Play around with it.
I think the logo in the nav, all blue is fine for now.
On May 19, 2020, at 12:42, María Morbán notifications@github.com wrote:
@Morban15 commented on this pull request.
In app/assets/styles/styles.css:
- background: #1a1451;
- padding: 0.5em 1.5em; I got it
But, the logo is inside the nav. For mobile this is how it looks
It can be fixed if we move out the logo from the nav. Should I do it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
@cosola I think there is a need to revisit some of the content of the newsletter. There's no mention in the text that the students graduated. All that exists is the content over the header image. Even if we use the title Our Awesome Graduation, there isn't any mention of the graduation in the introductory paragraph of the newsletter to ground the statement.
@Morban15 Can you change the title to Our Awesome Graduation. This matches the Spanish version. Please change the meta description to Conquered Steps.
I think the best option for now is to keep consistent with the Spanish version.
Thanks! Good work on the design. It helped to point out the need for consistency. I think we'll improve with the next version and for now we just need to get this work merged.
I'm going to squash + merge this in since it has a lot of commits.
newsletter.macile.org/es