search

cosola-salvia / news.macile.org

The MACILE program news section. Includes newsletters and bulletins.
https://news.macile.org
0 stars 0 forks source link

New header design bulletin #121

Closed Morban15 closed 4 years ago

Morban15 commented 4 years ago

@misscs chemical-work.surge.sh

misscs commented 4 years ago

I don't see the new header at that URL. It just loads the old header.

Morban15 commented 4 years ago

I don't see the new header at that URL. It just loads the old header.

What appears first is the landing page. chemical-work.surge.sh/bulletin/

misscs commented 4 years ago

I don't see the new header at that URL. It just loads the old header.

What appears first is the landing page. chemical-work.surge.sh/bulletin/

🤦 doh you are totally right. thank you! my bad there. totally forgot I needed to navigate.

misscs commented 4 years ago

The same restructuring of the HTML would apply here.

I like the idea of the linear gradient! Clever. Two small changes

  1. Let's use 0.1 for the alpha transparency, we still want the photo to shine.
  2. Can you reverse the linear gradient so the top is lighter and the bottom is darker? this way we can see the faces but blur a bit of the boring desks.
cosola commented 4 years ago

@Morban15 , the heading for the bulletin is moving in the right direction and looking nice. The bg image is an issue. It is repeated below. As I said before, a plain background is likely the best option for this issue. We don't have a good selection of images.

The title: "We are the adventurers; the real founders" relates to the group pictures that follow.

Make the changes to nav and header that Ms. Sarahe showed you this afternoon.

Morban15 commented 4 years ago

👍

On Mon, May 18, 2020, 7:02 PM cosola notifications@github.com wrote:

@Morban15 https://github.com/Morban15 , the heading for the bulletin is moving in the right direction and looking nice. The bg image is an issue. It is repeated below. As I said before, a plain background is likely the best option for this issue. We don't have a good selection of images.

The title: "We are the adventurers; the real founders" relates to the group pictures that follow.

Make the changes to nav and header that Ms. Sarahe showed you this afternoon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cosola-salvia/news.macile.org/pull/121#issuecomment-630478975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CKNQNUOIS7POLL7XDV6TRSG47FANCNFSM4NBXM34A .

misscs commented 4 years ago

@Morban15 I don't any commits that indicate that this branch was updated with changes from release-branch. Where you able to merge the changes from dev into release-branch?

Morban15 commented 4 years ago

No

On Mon, May 25, 2020, 11:07 AM cs notifications@github.com wrote:

@Morban15 https://github.com/Morban15 I don't any commits that indicate that this branch was updated with changes from release-branch. Where you able to merge the changes from dev into release-branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cosola-salvia/news.macile.org/pull/121#issuecomment-633614360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CKNRLPPNNCUPZS765KI3RTKCSFANCNFSM4NBXM34A .

misscs commented 4 years ago

No … On Mon, May 25, 2020, 11:07 AM cs @.***> wrote: @Morban15 https://github.com/Morban15 I don't any commits that indicate that this branch was updated with changes from release-branch. Where you able to merge the changes from dev into release-branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CKNRLPPNNCUPZS765KI3RTKCSFANCNFSM4NBXM34A .

Do you feel comfortable making those updates or are there too many merge conflicts?

Morban15 commented 4 years ago

It's a little confusing, but I was doing it and the computer died.

On Mon, May 25, 2020, 12:28 PM cs notifications@github.com wrote:

No … <#m-1137470588270214253> On Mon, May 25, 2020, 11:07 AM cs @.***> wrote: @Morban15 https://github.com/Morban15 https://github.com/Morban15 I don't any commits that indicate that this branch was updated with changes from release-branch. Where you able to merge the changes from dev into release-branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#121 (comment) https://github.com/cosola-salvia/news.macile.org/pull/121#issuecomment-633614360>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CKNRLPPNNCUPZS765KI3RTKCSFANCNFSM4NBXM34A .

Do you feel comfortable making those updates or are there too many merge conflicts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cosola-salvia/news.macile.org/pull/121#issuecomment-633643518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CKNXEKACQKJ7IEFXD5UDRTKMDZANCNFSM4NBXM34A .

misscs commented 4 years ago

It's a little confusing, but I was doing it and the computer died. Here we don't have electricity.

Yes, merge conflicts are always a bit confusing, especially when you have to take code from both commits. Sorry to hear about the electricity problems. Just let me know in chat if/when that happens. It's been very bad these days. We didn't have power this morning.

misscs commented 4 years ago

@Morban15 We updated the branch with the changes in the dev. To avoid holding up this PR, I opted to open #132 to refactor the nav so we can apply a class to it for the shared styles