search

cospired / i18n-iso-languages

i18n for ISO 639-1 language codes
MIT License
52 stars 29 forks source link

Added Hebrew Language updated code #31

Closed pchhajed closed 4 years ago

pchhajed commented 4 years ago

https://developers.google.com/hotels/hotel-prices/api-reference/language-codes

he is deprecated now. So adding iw.

pchhajed commented 4 years ago

@e110c0 Please review changes.

e110c0 commented 4 years ago

the library is based on ISO 639 language codes, which uses he for Hebrew since 1989:

he: Modern Hebrew. Code changed in 1989 from original ISO 639:1988, iw. (cf. https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes)

while it looks like the rest of the google api language codes are following the ISO 639, it is explicitly not using the ISO 630-1 code for Hebrew. It actually corrected all other .differences in codes (see the other deprecated codes and their substitutes).

To keep the library conform to ISO 630, this change can not be merged.