Closed Lagovas closed 2 years ago
If it's possible, in future we could add files like the CHANGELOG_DEV.md
and CHANGELOG.md
to CI blacklist to avoid triggering it. Or simply add [skip ci]
to such "text only" commits' titles to avoid wasting resources.
It is the second approach to fix flaky tests in acra-censor package by fixing race conditions in querywriter. What was done:
writer.queries
wrapped with RW mutex to avoid race conditions and make it more predictable in tests-race
flag for unit tests to detect race conditions. we used to old version of boltdb that are not maintained more. And it has race condition issues detected with race detector. So I updated boltdb dependency to new one that hasn't such issues (etcd-io/bbolt#187).-race
flag. Race detector increase time of tests and actually we don't need to run it trice with this flag. We can use latest version that should have the newest updates in go compiler.-v
flag fromgo test
command because of it generates 400k+ log lines that we don't use actually. It's enough to use default mode where will be logged failed test with name and line of error. And we would need to download 400k log lines to grep failed test name.GODEBUG=tls13=1
because of it doesn't work anymore since go1.14 where tls1.3 support turned on by default.Checklist