In one of my previous PRs I didn't remove logging encrypted data*( And @iamnotacake found it when tested eng demo.
We don't need to log encrypted data even for debugging because it will significantly grow log's size.
Plus, we should avoid logging any data because in the future somebody may leave it in code in decrypted form or log before encryption. Just because code is complicated and it is hard to keep in mind all these problems like security, code conventions, design, etc.
In one of my previous PRs I didn't remove logging encrypted data*( And @iamnotacake found it when tested eng demo.
We don't need to log encrypted data even for debugging because it will significantly grow log's size. Plus, we should avoid logging any data because in the future somebody may leave it in code in decrypted form or log before encryption. Just because code is complicated and it is hard to keep in mind all these problems like security, code conventions, design, etc.
Checklist