Found that go generate generates new files that not under git control. This instructions generate files in acra/keystore/kms/base/mocks folder. But we use mocks from acra/keystore/mocks. I think it was tested locally from keystore/kms folder and left as is. But we run and stay with approach of running from root of repo, so I updated paths to generate them where they are expected.
Also, found that my local mocker version v2.12.3 cannot re-generate mocks (when I tried to test with new paths) fails due to variables' name similar to package (context name used and similar to context package), and produced extra warnings. So, tested and re-generated with fresh v2.14.0 version to be sure that tests pass with new paths.
Found that
go generate
generates new files that not under git control. This instructions generate files inacra/keystore/kms/base/mocks
folder. But we use mocks fromacra/keystore/mocks
. I think it was tested locally fromkeystore/kms
folder and left as is. But we run and stay with approach of running from root of repo, so I updated paths to generate them where they are expected.Also, found that my local mocker version
v2.12.3
cannot re-generate mocks (when I tried to test with new paths) fails due to variables' name similar to package (context
name used and similar tocontext
package), and produced extra warnings. So, tested and re-generated with fresh v2.14.0 version to be sure that tests pass with new paths.Checklist