Found, that tests for acra-rollback do nothing and don't check that last query returns anything before iteration:
result = self.engine_raw.execute(acrarollback_output_table.select())
result = result.fetchall()
for data in result:
self.assertIn(data[0], source_data)
And they succeed even with errors like key 'keypair1' not found.
So, fixed the name of keypairs and added additional check that there are anything to iterate.
Found, that our GetDriverConnectionStringHost method incorrectly parses usernames that don't look like valid schema for net.URL. So, replaced custom parsing logic to use an appropriate function from the target driver that knows how to deal with its own custom connection string.
Found, that tests for acra-rollback do nothing and don't check that last query returns anything before iteration:
And they succeed even with errors like
key 'keypair1' not found. So, fixed the name of keypairs and added additional check that there are anything to iterate.Found, that our
GetDriverConnectionStringHostmethod incorrectly parses usernames that don't look like validschemafornet.URL. So, replaced custom parsing logic to use an appropriate function from the target driver that knows how to deal with its own custom connection string.Checklist