Run and pin bindgen - Githubissues

cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.

https://www.cossacklabs.com/themis

Apache License 2.0

1.85k stars 143 forks source link

Run and pin bindgen #1008

Closed G1gg1L3s closed 1 year ago

G1gg1L3s commented 1 year ago

You wouldn't believe but the failing bindgen tests in #1007 are caused by the bindgen which again updated and changed the format.

So, I propose pinning the exact version on CI just to save our time. Though you would have to make sure to use the correct bindgen version while developing locally.

Checklist

[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Changelog is updated (in case of notable or breaking changes)

Lagovas commented 1 year ago

please, add to our internal checklist that we should up bindgen version on periodically on new release. IMHO, we should not use outdated library and much better to keep updated periodically, at least every release