Merge stable - Githubissues

cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.

https://www.cossacklabs.com/themis

Apache License 2.0

1.85k stars 143 forks source link

Merge stable #1013

Closed Lagovas closed 1 year ago

Lagovas commented 1 year ago

merge stable to master

Checklist

[x] Changelog is updated (in case of notable or breaking changes)

vixentael commented 1 year ago

@Lagovas @G1gg1L3s let's merge?

G1gg1L3s commented 1 year ago

I have no objections. But, should we run the tests again? There is a high chance that something broke since that time, but even if it did, should we fix it here or merge and then fix?

vixentael commented 1 year ago

yes please

G1gg1L3s commented 1 year ago

Hmm, I'm not sure how to do this. Also it says that master is out-of-date and I don't have rights to update it directly, only though a PR. So, I'm not sure what to do and I need help, probably from @Lagovas.

vixentael commented 1 year ago

@G1gg1L3s try again? you should see the following

G1gg1L3s commented 1 year ago

Nope, still doesn't work

vixentael commented 1 year ago

@G1gg1L3s how about closing this PR and creating a new one stable -> master?

G1gg1L3s commented 1 year ago

Hmm, let's try :)