search

cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.
https://www.cossacklabs.com/themis
Apache License 2.0
1.85k stars 143 forks source link

Merge Stable #1019

Closed G1gg1L3s closed 9 months ago

G1gg1L3s commented 1 year ago

The continuation of #1013

vixentael commented 1 year ago

macos tests are failing 😢

G1gg1L3s commented 1 year ago

Among all the options, the worst fell out :c

The MSYS2 also fails, but due to the incorrect hashes which can only be updated after the merge.

Lagovas commented 1 year ago

and macos... what are our actions after successful tests except msys2? we merge it into the master, update hashes for msys2, and what do next?

G1gg1L3s commented 9 months ago

Do you remember what we planned to bring in this PR except windows related changes?)

If I remember correctly, we planned to merge this into master and consider that the release is made. The other wrappers would be released latter. Though I don't know what is the current state. At the time of this PR, we didn't have rust, android, objc and react wrappers released and ios wrappers weren't even prepared for the release. As for today, I know that we don't have rust released where the others are unknown to me.

Lagovas commented 9 months ago

wow, green tests except msys. what we need for green msys?

G1gg1L3s commented 9 months ago

what we need for green msys?

Hmm, since we already have release assets for 0.15.0, we can specify hashes of those and it should work. I will try to create a separate PR for this to see what happens.