search

cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.
https://www.cossacklabs.com/themis
Apache License 2.0
1.88k stars 143 forks source link

improve android example: remove second launcher and fix the manifest #1052

Closed radetsky closed 3 months ago

radetsky commented 3 months ago

During the example test, I found the following deficiencies:

  1. Two application icons instead of one.
  2. SecureMessage test was not happening.
  3. The app was not loading on the API 35 + 16k page memory platform.

Fixed:

  1. fixed manifest. Now there is one icon. And the application loads adequately.
  2. Added code to start SecureMessage activity.

The example application was tested on:

  1. Android 10 phone
  2. API 33 Simulator
  3. API 34 Simulator
  4. API 35 Simulator
  5. API 35+16k Simulator

Also, I think we should accept the PR https://github.com/cossacklabs/themis/pull/1051 It works on 35+ Simulators and does not crash the test application.

Checklist

radetsky commented 3 months ago

I answered you in private, but yes, I tested it on Android 10 phone + API 33-35 on Simulators. Thank you.