cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.
https://www.cossacklabs.com/themis
Apache License 2.0
1.87k stars 143 forks source link

rust: Suppress "clippy::needless_borrow" #971

Closed ilammy closed 1 year ago

ilammy commented 1 year ago

Latest Clippy got this new lint and it's, like, everywhere in the codebase. Initially I wanted to oblige the piece of metal, but after fixing up wave after wave of warnings I decided that it is enough and I won't be a slave to the machine, given that in some cases the changes make the code less aesthetically pleasing.

Also, teach CI to test with both Rust 1.51 (the oldest version we support) and stable. If only stable breaks, that's likely because of the new Clippy.

Checklist