Update API usage to OpenSSL 3 (RSA)

cossacklabs / themis

Easy to use cryptographic framework for data protection: secure messaging with forward secrecy and secure data storage. Has unified APIs across 14 platforms.

https://www.cossacklabs.com/themis

Apache License 2.0

1.87k stars 143 forks source link

Update API usage to OpenSSL 3 (RSA) #993

Closed iamnotacake closed 1 year ago

iamnotacake commented 1 year ago

Second part regarding changes that replace deprecated OpenSSL API usage with new alternatives from v3. This time related to RSA keys serialization/deserialization, and few other related places.

Checklist

[x] Change is covered by automated tests
[ ] Benchmark results are attached (if applicable)
[x] The coding guidelines are followed
[x] ~Public API has proper documentation~
[x] ~Example projects and code samples are up-to-date (in case of API changes)~
[ ] Changelog is updated (in case of notable or breaking changes)

ilammy commented 1 year ago

Tests pass ☀️

LGTM, provided a decision on OpenSSL 1.0.2 support is made (followed by some reverts, if we still support it).

iamnotacake commented 1 year ago

BTW, I managed to build (and even debug) libsoter with OpenSSL 1.0.2g. Using CLion (CMake project) and Docker (Ubuntu 16.04 with compiler and openssl being added). Even though current CMakeLists.txt requires CMake 3.8, it worked with CMake 3.5.1 that was available on old Ubuntu. Had to lower the version and add include_directories(include) to make it work though.

Lagovas commented 1 year ago

due to tests fails because of one dependency increased required version of cargo and this PR merges into the temporary branch before merging to master, we can merge it to it, unblock final reviewing and fixing tests in separate PR #995