FriesischScott commented 4 years ago

The Input has been rewritten. Instead of individual member properties per input type there is now only one property Members which includes all of them. The properties per type have been made dependent by parsing the cell array Members.

The Samples class has been removed. Mapping between the spaces has to be done at the point where it is needed through the appropriate methods, e.g. map2physical, map2stdnorm.

All algorithms in opencossan.simulations have been adapted and completely refactored.

Tests for the simulations and some of the optimizations are already included.

Everything that was proven to work before still works.

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into development will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           development      #33   +/-   ##
============================================
  Coverage        15.76%   15.76%           
============================================
  Files              652      652           
  Lines            26769    26769           
============================================
  Hits              4221     4221           
  Misses           22548    22548

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a61354...1a61354. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into development will decrease coverage by 2.17%. The diff coverage is 75.72%.

@@               Coverage Diff               @@
##           development      #33      +/-   ##
===============================================
- Coverage        17.67%   15.49%   -2.18%     
===============================================
  Files              750      656      -94     
  Lines            33334    26943    -6391     
===============================================
- Hits              5892     4176    -1716     
+ Misses           27442    22767    -4675

Impacted Files	Coverage Δ
...nhancedBayesianNetwork/computeProbabilisticNodes.m	`0.00% <0.00%> (ø)`
...tworks/@EnhancedBayesianNetwork/probabilisticSRM.m	`0.00% <0.00%> (ø)`
...andom/@LargeIRandomVariable/LargeIRandomVariable.m	`100.00% <ø> (ø)`
...andom/@NormalRandomVariable/NormalRandomVariable.m	`100.00% <ø> (ø)`
...andom/@SmallIRandomVariable/SmallIRandomVariable.m	`100.00% <ø> (ø)`
...dom/@UniformRandomVariable/UniformRandomVariable.m	`100.00% <ø> (ø)`
...dom/@WeibullRandomVariable/WeibullRandomVariable.m	`100.00% <ø> (ø)`
+opencossan/+common/+inputs/@Function/Function.m	`79.41% <ø> (+2.94%)`	:arrow_up:
+opencossan/+common/@CossanObject/CossanObject.m	`53.33% <ø> (-46.67%)`	:arrow_down:
...encossan/+inference/@ModelUpdating/ModelUpdating.m	`0.00% <0.00%> (ø)`
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ff6b36...0aa168c. Read the comment docs.

FriesischScott commented 4 years ago

I will update the tutorials to make them work. But I will make the random variable changes on a different branch.

FriesischScott commented 4 years ago

I fixed the main tutorials and adapted them to the changes. Ignore the failing coverage check. There is some issue with codecov messing up the base coverage used for comparison.

FriesischScott commented 4 years ago

@etheban Did you have any chance to take another look at this?

FriesischScott commented 4 years ago

@etheban Any chance we can finally do this?

etheban commented 4 years ago

Sure. We need another 2 dedicated days.

Edo

-- Edoardo Patelli Centre for Intelligent Infrastructure, University of Strathclyde

From: Jasper Behrensdorf notifications@github.com Reply to: cossan-working-group/OpenCossan reply@reply.github.com Date: Monday, 5 October 2020 at 19:48 To: cossan-working-group/OpenCossan OpenCossan@noreply.github.com Cc: Edoardo Patelli edoardo.patelli@strath.ac.uk, Mention mention@noreply.github.com Subject: Re: [cossan-working-group/OpenCossan] New Input and removal of Samples (#33)

@ethebanhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fetheban&data=02%7C01%7Cedoardo.patelli%40strath.ac.uk%7Ca6cbe7996d1648f6e8ef08d8695f26ea%7C631e0763153347eba5cd0457bee5944e%7C0%7C0%7C637375205262979961&sdata=5BjO8eae8TidqFN5fjPH1971cCRiVWb2xt5ug9I729Q%3D&reserved=0 Any chance we can finally do this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcossan-working-group%2FOpenCossan%2Fpull%2F33%23issuecomment-703819539&data=02%7C01%7Cedoardo.patelli%40strath.ac.uk%7Ca6cbe7996d1648f6e8ef08d8695f26ea%7C631e0763153347eba5cd0457bee5944e%7C0%7C0%7C637375205262989955&sdata=PpFZ2S8SoNNJ6I3D2Rawm15oybWOeMrncGye9Y35qQw%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADBXT42TFCVDZECJHCLFGG3SJIIFDANCNFSM4NHWKE6A&data=02%7C01%7Cedoardo.patelli%40strath.ac.uk%7Ca6cbe7996d1648f6e8ef08d8695f26ea%7C631e0763153347eba5cd0457bee5944e%7C0%7C0%7C637375205262989955&sdata=FNQ68TBuRqUKSzvMmdqsZDPAj2xwbhwQAWZ2%2FK5Hz4o%3D&reserved=0.

teobros commented 4 years ago

Sure. We need another 2 dedicated days. Edo

But we discussed about this in Albarella! You were ok with this in July!

FriesischScott commented 1 year ago

I'm closing this because I'm annoyed that it shows up as an open PR for me in Github. The branch is still there if anyone ever needs it.

cossan-working-group / OpenCossan

New Input and removal of Samples #33

Codecov Report

Codecov Report