Optimisation/constraint evalutate not comply with worker policy

etheban commented 4 years ago

Tutorials optimisation do not work.

Evaluate methods of ObjectiveFunction and Constraint should work at least like the other workers.

TableOutput=evaluate(workerObject,TableInput);

If you need another function add it but the behaviour of methods should not be changed without a good reason.

The current method evaluate of ObjectiveFunction and Constraint should be renamed. e.d evaluate@ObjectiveFunction -> ANYOTHERNAME@ObjectiveFunction

FriesischScott commented 4 years ago

If you need another function add it but the behaviour of methods should not be changed without a good reason.

What do you mean? It's exactly the way it is in the stable and has probably always been like this.

etheban commented 4 years ago

Still a bad implementation created before the implementation of table in MATLAB.

Let's use evaluate as defined in worker and if you need another dedicate method (i.e. rename the current one) is fine.

I don't particularly like evaluate@opencossan.worker.Worker

Get Outlook for Androidhttps://aka.ms/ghei36

From: Jasper Behrensdorf notifications@github.com Sent: Saturday, May 23, 2020 11:27:28 AM To: cossan-working-group/OpenCossan OpenCossan@noreply.github.com Cc: Edoardo Patelli edoardo.patelli@strath.ac.uk; Author author@noreply.github.com Subject: Re: [cossan-working-group/OpenCossan] Optimisation/constraint evalutate not comply with worker policy (#36)

If you need another function add it but the behaviour of methods should not be changed without a good reason.

What do you mean? It's exactly the way it is in the stable and has probably always been like this.

cossan-working-group / OpenCossan