search

costastf / locationsharinglib

A library to retrieve coordinates from an google account that has been shared locations of other accounts.
MIT License
170 stars 29 forks source link

Feature: Include Timezone as Field #108

Closed Abolfazl closed 1 year ago

Abolfazl commented 1 year ago

Would there be any possibility of including the users timezone as one of the fields?

I am currently able to implement this myself by doing:

from tzwhere import tzwhere
user = service.get_coordinates_by_nickname('USER')
tz = tzwhere.tzwhere()
timezoneName = tz.tzNameAt(user.latitude, user.longitude) # Returns "America/Los_Angeles"
costastf commented 1 year ago

Hi @Abolfazl , although i think this is a nice improvement, i would not want to bring in more dependencies, especially one that would bring in numpy just for a very small feature like this. I think it would be better to implement this client side like you did. Thoughts?

Abolfazl commented 1 year ago

Yes that is true. I can continue to implement it client side