search

costastf / locationsharinglib

A library to retrieve coordinates from an google account that has been shared locations of other accounts.
MIT License
170 stars 29 forks source link

Lib fix #43

Closed lufton closed 5 years ago

lufton commented 6 years ago
royduin commented 6 years ago

Please merge @costastf and tag a new version.

zavorra commented 5 years ago

please merge this patch

GreatAnubis commented 5 years ago

That patch works as expected! Thank you @lufton

michaelarnauts commented 5 years ago

Works perfect! Used this to generate a new cookie file, and that file is working fine with the current version packaged in HASS.

@costastf what's holding back from getting this merged in?

costastf commented 5 years ago

The reason is that the solution is very hardcoded and I consider it very fragile. On the other hand of course the current state is broken for most people so that does not say much :) . My plan is to completely decouple the library from the cookie getting process, so that the library requires the cookies as an argument. I am working on a tool that would use a browser for the user to go through the normal authentication process and retrieving the cookies using selenium. That still requires some work so in the mean time I will merge this and make a new version during the weekend.

royduin commented 5 years ago

Are you also tagging a new release for the time being?

costastf commented 5 years ago

I have released v3.0.11 with this patch already.

royduin commented 5 years ago

Don't see it here: https://github.com/costastf/locationsharinglib/releases or here: https://github.com/costastf/locationsharinglib/tags

costastf commented 5 years ago

I am not using github for releasing. You can find the released artifact in pypi https://pypi.org/project/locationsharinglib/