search

costastf / locationsharinglib

A library to retrieve coordinates from an google account that has been shared locations of other accounts.
MIT License
170 stars 29 forks source link

SUGGESTION: Implement service.get_timestamp_by_nickname('NICKNAME') #95

Closed eclipsek20 closed 2 years ago

eclipsek20 commented 2 years ago

Like the titles says, this would enable the ability to get info on the last time the location was located. This would be very useful since sometimes google maps can have delays of up to 3 hours before the location finally updates.

costastf commented 2 years ago

Hi @eclipsek20 , thanks for the suggestion. Any chance you might want to give the implementation a try yourself and make an MR for it? It would basically be a small refactor of https://github.com/costastf/locationsharinglib/blob/main/locationsharinglib/locationsharinglib.py#L234

eclipsek20 commented 2 years ago

@costastf well whilst I was writing this I wasn't aware of how easy it was to implement my own implementation, I added the time and other stuff. Anyway thanks for the answer!

costastf commented 2 years ago

Will you make an MR with those changes so others can benefit from your work?

eclipsek20 commented 2 years ago

I will try but I can not guarantee anything.

costastf commented 2 years ago

If you need any help, please let me know.

eclipsek20 commented 2 years ago

Okay I have no clue what I done but I did something? I hope I correctly submitted it.