search

costastf / locationsharinglib

A library to retrieve coordinates from an google account that has been shared locations of other accounts.
MIT License
170 stars 29 forks source link

Add extra features. #96

Closed eclipsek20 closed 1 year ago

eclipsek20 commented 2 years ago

Before pushing the changes, please verify that it works as intended. Changes include: -Separation of Latitude and Longitude by nickname (example: service.get_latitude_by_nickname('Nickname') -Timestamp of the retrieval of location by nickname (in UNIX format in ms (i think)) (example: service.get_timedate_by_nickname('Nickname')

costastf commented 2 years ago

Added a couple of simple comments. Great work! Would you like to also add yourself to the contributors file for these changes?

eclipsek20 commented 2 years ago

I have no clue what is going on, this is my first time publishing in such a manner, do I have to reply to these comments? As for the contributors file, if it runs correctly then please do, this has been the peak confusion I ever had on GitHub. Thanks for the complements.

costastf commented 2 years ago

😁 officially the process is that you amend the code according to the comments until it is acceptable to merge. I think you are doing great, but if this is too much for you I can just fix and merge and add you to the contributors.

eclipsek20 commented 2 years ago

Hi. Sorry for the late reply. I have no clue on what to do, please do patch it yourself, if you think I did too little I am okay with not being included in the list, anyway best of luck!

costastf commented 2 years ago

I am off my off parental leave next week and I will help you do this. I will make an MR to your branch with the proposed chances and then I will accept that. Sounds ok to you?

costastf commented 1 year ago

@eclipsek20 hope you are well! Better late than never they say.. so v4.2.0 holds your changes. Thanks!

eclipsek20 commented 1 year ago

I'm doing fine thank you, I apologize for not replying to you, it flew over my head. Hope you are doing fine as well!

costastf commented 1 year ago

No worries! Thanks for your effort!