search

costastf / toonapilib

A library to interact with eneco's "Toon" smart meter via their official api https://api.toon.eu
MIT License
15 stars 11 forks source link

Handle statuscode 429 #33

Closed frenck closed 4 years ago

frenck commented 5 years ago

When the Toon API limit is reached / hit, the API throws an HTTP 429 status code.

This should be handled properly by the library (e.g., by implementing a proper back off).

costastf commented 4 years ago

i think that the default caching covers this so there is no need to implement anything more towards this issue.

frenck commented 4 years ago

? That is not an answer or solution. These can be triggered by all kinds of things, e.g., temporary less capacity, a ton of temperature changes send in the past x minutes.

Caching is not a magical keyword in this case.

costastf commented 4 years ago

I realize that and I am not super happy with the way things are handled but I am also very short on extra personal time and since things are working I would rather spend my very limited time into solving things that actually create problems. I would be more than happy to accept MRs to fix this the proper way.

On Sun, Dec 1, 2019, 19:42 Franck Nijhof notifications@github.com wrote:

? That is not an answer or solution. These can be triggered by all kinds of things, e.g., temporary less capacity, a ton of temperature changes send in the past x minutes.

Caching is not a magical keyword in this case.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/costastf/toonapilib/issues/33?email_source=notifications&email_token=ABDMK22Q7P6J6UMV4DKHRWDQWQAP3A5CNFSM4G7G5G7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRRS5Y#issuecomment-560142711, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDMK23PBCODSLLDWH7AGS3QWQAP3ANCNFSM4G7G5G7A .