search

costerwi / dwdatareader

Python module to interact with Dewesoft DWDataReaderLib shared library
MIT License
14 stars 9 forks source link

Update library to DWDataReader v4.2.0.31 #66

Closed costerwi closed 1 week ago

costerwi commented 3 months ago

Attempting to update the library files as requested in #65 but running into some errors which will require a closer look.

costerwi commented 3 months ago

DLL.DWGetScaledSamples is returning an error "CAN not supported" for some reason

costerwi commented 1 week ago

Dewesoft seems to have introduced a bug in this version of the library where all channels whose channel_index begins with "CAN" will fail with "CAN not supported" when we call DLL.DWGetScaledSamples for those channels.

costerwi commented 1 week ago

I created a ticket with Dewesoft:

134515 Bug: Channels no longer supported in DWDataReaderLib_v4_2_0_31 The attached example was readable in 4.2.0.25 but in the latest 4.2.0.31 it now gives error 10 when attempting DWGetScaledSamples() or DWGetRawSamples() on certain channels.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

costerwi commented 6 days ago

The CAN channels are a new and permanent restriction. It's just coincidence that this project's test data includes them so I will continue to ignore those channels . Here is the message back from Dewesoft:

We never truly supported reading of CAN channels with DWDataReader - yes you could access the channel but the values were not always correct as they can not be decoded properly. And since it can not be decoded properly developers added the error message in v4.2.0.26.

CAN channels are “online decoded” in DewesoftX from the “raw message channel” when reviewing them. DWDataReader is not able to do the decoding of those signals. There is possibility to put those channels to either formula (one by one) or if there are more to “math statistics” (multiple with one math). This will transform those signals to “normal decoded channels” which DWDataReader will be able to read.

We currently have a feature request exploring the possibility of decoding the CAN channels in the future. At this time, however, the proposed work around would be the only way to get this functioning "normally."