search

cosullivan / SmtpServer

A SMTP Server component written in C#
MIT License
675 stars 159 forks source link

ILogger interface depricated? #170

Closed large closed 8 months ago

large commented 2 years ago

Still working on my v9.x upgrade (coming from v7.x so this might be gone a long time) You had an .Logger option, is that removed / change?

A logger option could be good for debug info and others, I vote to include it into ServiceProvider.cs :) https://github.com/cosullivan/SmtpServer/blob/77d3188c8545c4e8ee39dca6fa3626d8f0d40512/Src/SmtpServer/ComponentModel/ServiceProvider.cs#L9

cosullivan commented 2 years ago

Hi,

I removed the Logger in favor of using events, see the SessionTracingExample as an example of this. https://github.com/cosullivan/SmtpServer/blob/master/Examples/SampleApp/Examples/SessionTracingExample.cs

The logger (from memory) wasn't logging anything that isn't currently available from using events.

How were you using the logger previously? I am happy to put a logger back in if there are things that can't be determined via the events.

large commented 2 years ago

Hi @cosullivan , I have checked and you are quite right 👍 I used the logger internally for debug reasons and it was never given any data from SmtpServer only the objects I included. Maybe remove the files for Logger interface the the NullLogger in a future release then?

cosullivan commented 8 months ago

This has now been removed.