search

cosyneco / MediaPipe.NET.Runtime

Native runtime package for MediaPipe.NET.
MIT License
21 stars 6 forks source link

Fix deployment #8

Closed Speykious closed 2 years ago

Speykious commented 2 years ago

Finally, we managed to publish this to Nuget! This PR fixes CI deployment issues once and for all.

Speykious commented 2 years ago

Oof, I just realized that I didn't synchronize the CI workflow well. gimme a sec

Speykious commented 2 years ago

Well now it does, perfect :D

Speykious commented 2 years ago

That's fine, however I don't think we need a dedicated deploy step for production. They'd both be the same without any modification. How about I just edit the environment as environment: ${{ github.event.environment }}?

sr229 commented 2 years ago

That's fine, however I don't think we need a dedicated deploy step for production. They'd both be the same without any modification. How about I just edit the environment as environment: ${{ github.event.environment }}?

I tried that and it didn't work so the best course of action is hardocde it

Speykious commented 2 years ago

Awesome! It looks like ${{ github.event.release.prerelease && 'Pre-release' || 'Production' }} is a perfect fit. The Production deployment "error" up there is just me cancelling it - we've already published the packages.