cotag / orbicular

A CSS based circular progress bar for AngularJS
MIT License
47 stars 15 forks source link

Error Loading Angular module #14

Closed LivesleyWA closed 9 years ago

LivesleyWA commented 9 years ago

This was working until I updated the module from bower last night (17th Oct). It no longer loads into Angular causing the application to fail.

I dont' have an error information beyond the angular report https://docs.angularjs.org/error/$injector/nomod?p0=Orbicular

My code is angular.module("forums-application", ["angularMoment", "monospaced.mousewheel", "ngAnimate", "ngCookies", "ngRoute", "ngSanitize", "ngTagsInput", "ngTouch", "Orbicular", "uuid4", "ui.bootstrap"])

The orbicular.js file is being loaded and other Angular modules are being loaded.

stakach commented 9 years ago

Can you check version v3.0.2 works? There is no functional difference between that version and v3.1.0 - just AMD support.

I guess also confirm that there are no file not found errors in the console too.

LivesleyWA commented 9 years ago

Hi Stephen

Thanks for the prompt reply

v3.0.2 works fine.

I use requirejs to load the application so I am a little puzzled as to why I would have issues. I know that this line is invoked define('Orbicular', ['angular'], angularOrbicular);

An orbicular entry is included as part of the shim

var requireConfiguration:RequireConfig = { baseUrl: "", paths: { "angular": "angular/angular.min", "orbicular": "orbicular/orbicular", }, shim: { "angular": { exports: "angular" }, "orbicular": { deps: ["angular"] }, }, priority: [ "$", "angular" ], waitSeconds: 0 };

Alex Livesley

W. Alex Livesley President and CEO | Ilexium Incorporated www.ilexium.comhttp://www.ilexium.com | alex.livesley@ilexium.commailto:alex.livesley@ilexium.com 465 Bellevue Avenue #35 | Oakland | CA 94610 | USA

On Oct 17, 2014, at 10:09 PM, Stephen von Takach notifications@github.com<mailto:notifications@github.com> wrote:

Can you check version v3.0.2 works? There is no functional difference between that version and v3.1.0 - just AMD support.

I guess also confirm that there are no file not found errors in the console too.

— Reply to this email directly or view it on GitHubhttps://github.com/cotag/orbicular/issues/14#issuecomment-59599486.

LivesleyWA commented 9 years ago

OK - I have it now - it’s a case sensitivity issue.

The line define('Orbicular', ['angular'], angularOrbicular); defines the module name as Orbicular. In my requirejs configuration I had defined the name as orbicular. This worked fine when the file was not being loaded as an AMD module but having the name explicitly defined means that I needed to adjust my requirejs configuration.

Not your problem but mine.

Thanks for your help in any case as the workaround got me past a deadline.

You can close the ticket.

Alex Livesley

W. Alex Livesley President and CEO | Ilexium Incorporated www.ilexium.comhttp://www.ilexium.com | alex.livesley@ilexium.commailto:alex.livesley@ilexium.com 465 Bellevue Avenue #35 | Oakland | CA 94610 | USA

On Oct 17, 2014, at 10:43 PM, W. Alex Livesley alex.livesley@ilexium.com<mailto:alex.livesley@ilexium.com> wrote:

Hi Stephen

Thanks for the prompt reply

v3.0.2 works fine.

I use requirejs to load the application so I am a little puzzled as to why I would have issues. I know that this line is invoked define('Orbicular', ['angular'], angularOrbicular);

An orbicular entry is included as part of the shim

var requireConfiguration:RequireConfig = { baseUrl: "", paths: { "angular": "angular/angular.min", "orbicular": "orbicular/orbicular", }, shim: { "angular": { exports: "angular" }, "orbicular": { deps: ["angular"] }, }, priority: [ "$", "angular" ], waitSeconds: 0 };

Alex Livesley

W. Alex Livesley President and CEO | Ilexium Incorporated www.ilexium.comhttp://www.ilexium.com/ | alex.livesley@ilexium.commailto:alex.livesley@ilexium.com 465 Bellevue Avenue #35 | Oakland | CA 94610 | USA

On Oct 17, 2014, at 10:09 PM, Stephen von Takach notifications@github.com<mailto:notifications@github.com> wrote:

Can you check version v3.0.2 works? There is no functional difference between that version and v3.1.0 - just AMD support.

I guess also confirm that there are no file not found errors in the console too.

— Reply to this email directly or view it on GitHubhttps://github.com/cotag/orbicular/issues/14#issuecomment-59599486.

stakach commented 9 years ago

Glad you've got it sorted and good to know AMD is working!

LivesleyWA commented 9 years ago

Thanks - nice control btw - it was exactly what my customer wanted and save me a lot of development time. I would send you a link but it’s all behind a firewall as far as I know.

Alex Livesley

W. Alex Livesley President and CEO | Ilexium Incorporated www.ilexium.comhttp://www.ilexium.com | alex.livesley@ilexium.commailto:alex.livesley@ilexium.com 465 Bellevue Avenue #35 | Oakland | CA 94610 | USA

On Oct 18, 2014, at 12:24 PM, Stephen von Takach notifications@github.com<mailto:notifications@github.com> wrote:

Glad you've got it sorted and good to know AMD is working!

— Reply to this email directly or view it on GitHubhttps://github.com/cotag/orbicular/issues/14#issuecomment-59626449.