search

cotag / orbicular

A CSS based circular progress bar for AngularJS
MIT License
47 stars 15 forks source link

jquery dep? #3

Closed vecernik closed 10 years ago

vecernik commented 10 years ago

Hi Orbicular, thanks for creating such a beautiful directive for ng, I was looking for exactly such a thing. Are you sure there is a need for having jquery as a dependency in bower.json? It seems there is no real usage of it in the code afaik. I'd like to use Orbicular in my project which has no dep to jquery at all and I'd like to keep it that way if there is no good reason. Thanks.

stakach commented 10 years ago

Hi @vecernik you are correct. There is no need for jQuery - that is a legacy entry since issue #2 was resolved.

I'll remove it now.

stakach commented 10 years ago

Ahh I see what's going on. I'm still using jQuery for the tests - it's a dev dependency so no need to include it in production code.

stakach commented 10 years ago

Feel free to remove the jQuery dependency from the tests - happy to accept pull requests.