cotag / orbicular

A CSS based circular progress bar for AngularJS
MIT License
47 stars 15 forks source link

progress is never bigger than 180° #7

Closed gkielwasser closed 10 years ago

gkielwasser commented 10 years ago

This angular CSS based countdown directive looks nice but it's not working. The progress bar is never bigger than the half of the circle (180°). I think this issue is related to the "gt50" class. Could you have a look?

stakach commented 10 years ago

I have it working in a few projects and tests are passing Are you able to provide sample code? Which browsers are you testing in?

gkielwasser commented 10 years ago

Hi! I tested it on Chrome 33. I made a plunker to show what I meant.

http://plnkr.co/edit/R9GaSfIY0ffyWUMAgNBX?p=preview

gkielwasser commented 10 years ago

It works in Firefox but not I Chrome

stakach commented 10 years ago

Weird. It look like the SCSS compiler has removed a bunch of code. The CSS file in that plnkr is missing:

-webkit-transition: -webkit-transform 0.3s linear;
-moz-transition: -moz-transform 0.3s linear;
-ms-transition: -ms-transform 0.3s linear;
-o-transition: -o-transform 0.3s linear;
transition: transform 0.3s linear;

It only has the transition: transform 0.3s linear; statement will investigate if the latest SCSS release is stripping these out and update accordingly.

Once those statements are added back the code works as desired.

stakach commented 10 years ago

Hi @gkielwasser would you be able to confirm the changes in that commit work for you and I'll tag another release for bower.

stakach commented 10 years ago

I assume you are using grunt with autoprefixer for your builds? (default if using yeoman and angular-generator)

This fix should work for the current browsers (the only ones supported by default with that generator) and setting autoprefixer to support the last few browsers in your gruntfile should solve issues with backwards compatibility.

gkielwasser commented 10 years ago

Hi,

yes I'm using autoprefixer for my builds. Everythings work well with that fix! Thank you very much!