search

cotag / ruby-tls

Generic TLS for ruby
Other
6 stars 5 forks source link

tls server: allow requesting a client-cert #3

Closed arrtchiu closed 8 years ago

arrtchiu commented 8 years ago

I needed client TLS authentication, this patch triggers the client to send the cert.

Disclaimer: This is my first time using FFI library, I assume the pointer returned by SSL_load_client_CA_file is leaked -> I haven't spent any time figuring it out yet.

stakach commented 8 years ago

Looks good to me - I assume the the strings would be cleaned up when the SSL context is cleaned up as the only purpose for creating them is to attach to a context and they are not created if there is an error.

I'll cut a new gem release in the morning my time 👍 Thanks for the contribution!