cotag / ruby-tls

Generic TLS for ruby
Other
6 stars 5 forks source link

Ssl version #6

Closed HoneyryderChuck closed 7 years ago

HoneyryderChuck commented 7 years ago
stakach commented 7 years ago

Thanks for this! Looking at the OpenSSL docs I wasn't too keen to use the "this version only functions" as I would prefer to use the latest and greatest protocol available. So I have the version option define the minimum protocol version.

I've also provided a function to set the max protocol too, if you want to really lock it down.

So I've cut a new version of the GEM that works very similarly to what you've proposed here and you can see the changes here bf64374c78f3826413a4448e2a7c37bfe7b143bd

What do you think?

HoneyryderChuck commented 7 years ago

Wow, your patch definitely looks much better! :) Thx for that!