WordPress update to 4.9.8 and lots of other changes

[chriscroome]

This merge request only includes a WordPress version update and some plugin updates from me, the bulk of the changes have been made by @lwm and some by @sdgluck, the dev site seems fine so I think this is good to merge?

[decentral1se]

I raised some tickets on the git.coop ansible repo for the deployment of this, i think they need to be addressed before merging (i think, cant really remember - on mobile, cant find them now).

[chriscroome]

Thanks @lwm, sorry I had missed these issues:

• https://git.coop/cotech/ansible/issues/7
• https://git.coop/cotech/ansible/issues/8

Would you like to make the changes at https://git.coop/ and then we can test it on the dev server and if it is all OK then merge this in?

[decentral1se]

All good! I've just added some comments, so hopefully they can be resolved now.

Test plan sounds good, hope things don't blow up! Ping me to fix whatever I've broken :)

[chriscroome]

I have just updated the dev site:

https://dev.coops.tech/

The update script generated this error:

~/bin/update 
No local changes to save
Already up-to-date.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Generating autoload files
yarn install v1.10.1
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.82s.
gulp[28285]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed.
 1: 0x8daaa0 node::Abort() [gulp]
 2: 0x8dab75  [gulp]
 3: 0x90e327 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [gulp]
 4: 0xb5fd4b  [gulp]
 5: 0xb61d1a v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [gulp]
 6: 0x3095fe55be1d 
/home/cotechdev/bin/update: line 28: 28285 Aborted                 nodejs ./node_modules/gulp/bin/gulp.js
Success: WordPress database already at latest db version 38590.

However the sites seems OK so I assume it is safe to ignore this?

If someone could review this and merge dev into master then the live site will also update.

[chriscroome]

I have deleted the branch protection rule that was preventing this being merged without a review.

[decentral1se]

Thanks @chriscroome.

[chriscroome]

All these updates have now been reverted, see #106.