search

cotech / website

The Cooperative Technologists WordPress website
https://www.coops.tech/
GNU General Public License v3.0
24 stars 5 forks source link

Fix problems building Docker development environment from scratch #77

Closed floehopper closed 6 years ago

floehopper commented 6 years ago

I cherry-picked the 3 relevant commits from #76 and ran docker-compose up -d successfully from scratch. I'm no longer seeing the errors I reported in #65 and the development version of the website seems to work fine as far as I can tell. Thanks, @lwm!

As far as I understand it, the basic problem was that one of the containers was relying on Ubuntu Wily which reached the end of its life in July 2016. I believe this PR changes the code to use Xenial instead.

I plan to open a separate PR for the changes to the README that were included in #76.

I don't think the changes to web/app/themes/coop-tech-oowp-theme/package.json or web/app/themes/coop-tech-oowp-theme/yarn.lock that were included in #76 are really relevant to fixing this problem. I suspect they are just the result of some sort of update that is happening as part of the Docker "build".

Closes #65.

decentral1se commented 6 years ago

As far as I understand it, the basic problem was that one of the containers was relying on Ubuntu Wily which reached the end of its life in July 2016. I believe this PR changes the code to use Xenial instead.

Yep! I used the forked outlandishideas/docker-nginx-hhvm-bedrock, which actually removes HHVM, for whatever they were using it for and upgrades the PHP version to 7.1 - for whatever reason they were using it for.

Please note, if we were really interested in making sure this doesn't break again, we'd do 2 things:

1) Fork the fork, under the CoTech organisation - we pin our commits to the existing HEAD 2) Create a CoTech docker hub account and build our own image and use that instead

This would mean we'd never have something broken here in case outlandish go on experimenting with that repository and that docker hub account image.

I don't think the changes to web/app/themes/coop-tech-oowp-theme/package.json or web/app/themes/coop-tech-oowp-theme/yarn.lock that were included in #76 are really relevant to fixing this problem. I suspect they are just the result of some sort of update that is happening as part of the Docker "build".

I'd like to find out about that! I assume dependencies are out of date? They're not ignored.

nicksellen commented 6 years ago

Thanks all, looks good to me. I had forgot @conatus had built an updated version of the docker image in the outlandish dockerhub account.

It's still a temporary solution though for the reasons you mention @lwm. I started to switch to using standard nginx and php containers, but the terrible wifi made it a very slow process. That way we don't need to maintain custom images at all. I'll push that work when it's done.

decentral1se commented 6 years ago

Nice one!