Merging latest changes into live

[harryrobbins]

Immediately to fix the broken people page, but also to deploy some Docker updates

[chriscroome]

I updated the WordPress version in the composer.json file and ran the update script however the version of WordPress didn't change:

Installing dependencies (including require-dev) from lock file
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.
  - Installing johnpbloch/wordpress-core (4.8.2)
    Loading from cache

So I guess that means that we need to also update the composer.lock file when there is a new version of WordPress out? Or is this file somehow generated from the composer.json file?

[chriscroome]

I ran composer update --lock and then got:

Loading composer repositories with package information
Updating dependencies (including require-dev)                        
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package johnpbloch/wordpress (locked at 4.8.2, required as 4.9.1) is satisfiable by johnpbloch/wordpress[4.8.2] but these conflict with your requirements or minimum-stability.
  Problem 2
    - The requested package wpackagist-plugin/advanced-custom-fields (locked at 4.4.11, required as 4.4.12) is satisfiable by wpackagist-plugin/advanced-custom-fields[4.4.11] but these conflict with your requirements or minimum-stability.
  Problem 3
    - The requested package wpackagist-plugin/custom-post-type-ui (locked at 1.5.5, required as 1.5.6) is satisfiable by wpackagist-plugin/custom-post-type-ui[1.5.5] but these conflict with your requirements or minimum-stability.
  Problem 4
    - The requested package wpackagist-plugin/wp-piwik (locked at 1.0.17, required as 1.0.19) is satisfiable by wpackagist-plugin/wp-piwik[1.0.17] but these conflict with your requirements or minimum-stability.
  Problem 5
    - The requested package wpackagist-plugin/contact-form-7 (locked at 4.9, required as 4.9.1) is satisfiable by wpackagist-plugin/contact-form-7[4.9] but these conflict with your requirements or minimum-stability.
  Problem 6
    - The requested package wpackagist-plugin/acf-to-rest-api (locked at 2.2.1, required as 3.1.0) is satisfiable by wpackagist-plugin/acf-to-rest-api[2.2.1] but these conflict with your requirements or minimum-stability.
  Problem 7
    - Can only install one of: johnpbloch/wordpress-core[4.9.1, 4.8.2].
    - Can only install one of: johnpbloch/wordpress-core[4.9.1, 4.8.2].
    - johnpbloch/wordpress 4.9.1 requires johnpbloch/wordpress-core 4.9.1 -> satisfiable by johnpbloch/wordpress-core[4.9.1].
    - Installation request for johnpbloch/wordpress 4.9.1 -> satisfiable by johnpbloch/wordpress[4.9.1].
    - Installation request for johnpbloch/wordpress-core (locked at 4.8.2) -> satisfiable by johnpbloch/wordpress-core[4.8.2].

I haven't yet looked into the plugins but I think the issues with WordPress is that John P Bloch has moved his repo from here to here so I think -core needed adding in?

[nicksellen]

I don't have perfect understanding of composer, but did run into all these kind of problems before, and have the following understanding:

• if composer.lock is present then composer install will just install the stuff from there
• when updating composer.json you also need to trigger composer.lock to be updated or it'll have no effect
• composer update updates all dependency versions (within their specified range)
• composer update <depname> will update just that one
• the repo should always contain a valid composer.json / composer.lock combo
• during deployment, should always use composer install (or you may not have actually ever run/tested the site with that combination of dependencies)

Some links:

• https://www.engineyard.com/blog/composer-its-all-about-the-lock-file
• https://getcomposer.org/doc/01-basic-usage.md#updating-dependencies-to-their-latest-versions

[chriscroome]

Thanks for that @nicksellen, the dev site appears to be fine after those updates so I'm going to merge these changes in.