coteditor / CotEditor

Lightweight Plain-Text Editor for macOS
https://coteditor.com
Other
6.37k stars 432 forks source link

syntax covering full words, not only 'starting with' #1622

Closed xq369 closed 5 months ago

xq369 commented 5 months ago

Is your feature request related to a problem? Please describe. the syntax specifications require to define the 'starting with' string for each word when using short words that get repeated in other words, the syntax of both words gets mixed up

Describe the solution you'd like specify the string for the full word, not "starting with", so words do not get mixed up

Describe alternatives you've considered i've tried "ending with" but it does not bring any change

Additional context in this example there are 2 syntaxes mixed up:

Screenshot 2024-04-20 at 08 57 42

Add any other context or screenshots about the feature request here.

1024jp commented 5 months ago

when using short words that get repeated in other words, the syntax of both words gets mixed up

CotEditor is not designed so, in general. Could you share the syntax definition file to help us break down the problem?

In addition, please provide your environments:

xq369 commented 5 months ago

 CotEditor 4.8.0 MacOS 14.4.1

On 20 Apr 2024, at 12:30, 1024jp @.***> wrote:

when using short words that get repeated in other words, the syntax of both words gets mixed up

CotEditor is not designed so, in general. Could you share the syntax definition file to help us break down the problem?

In addition, please provide your environments:

CotEditor's version macOS vesion — Reply to this email directly, view it on GitHub https://github.com/coteditor/CotEditor/issues/1622#issuecomment-2067631944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIP62OZERWOBCZP7WBARZ3Y6I7UPAVCNFSM6AAAAABGQINZPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGYZTCOJUGQ. You are receiving this because you authored the thread.

1024jp commented 5 months ago

I tweaked the algorithm parsing such simple words in CotEditor 4.8.1, which was released yesterday. I suppose now it becomes better but let me know if the issue still exists.

xq369 commented 5 months ago

you've been working hard ! really appreciated

only see this now, as i've been travelling last weeks after updating to 3.8.2 and a quick look; it is better but not fully solved will look into it and come back to you

On 23 Apr 2024, at 11:29, 1024jp @.***> wrote:

I tweaked the algorithm parsing such simple words in CotEditor 4.8.1, which was released yesterday. I suppose now it becomes better but let me know if the issue still exists.

— Reply to this email directly, view it on GitHub https://github.com/coteditor/CotEditor/issues/1622#issuecomment-2071842857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIP62NDLR27WMLQMBUMHSLY6YSZPAVCNFSM6AAAAABGQINZPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRHA2DEOBVG4. You are receiving this because you authored the thread.

xq369 commented 5 months ago

thanks for reflecting so quickly when looking deeper, things actually got worse

for example this javascript when using / in a sentence, it takes out a long part of the script this is selected text, so you can see the original : 

this is the result: 

on separate lines it works ok : 

when using an array that contains /, like this (selected) array: 

this is the result: 

in the language that uses short commands (which i sent you) it still combines colors where it should not so it does not yet recognise when such combination is used as a single command 

as is defined here : 

On 23 Apr 2024, at 11:29, 1024jp @.***> wrote:

I tweaked the algorithm parsing such simple words in CotEditor 4.8.1, which was released yesterday. I suppose now it becomes better but let me know if the issue still exists.

— Reply to this email directly, view it on GitHub https://github.com/coteditor/CotEditor/issues/1622#issuecomment-2071842857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIP62NDLR27WMLQMBUMHSLY6YSZPAVCNFSM6AAAAABGQINZPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRHA2DEOBVG4. You are receiving this because you authored the thread.

xq369 commented 4 months ago

can you have a look at the syntax again please, because even after latest update it keeps misrepresenting even in javascript

this sentence 

becomes like this : 

and it is pretty inconvenient

Holywood verpakt Waarheid in een verhaal Politici, Kranten, TV & Social Media verpakken verhalen in de vorm van Waarheid Come U Next ! vertelt je de Waarheid

https://comeunext.glitch.me/

xq369 commented 4 months ago

also html is impacted : 

which should be : 

On 17 May 2024, at 05:54, xq369 @.***> wrote:

can you have a look at the syntax again please, because even after latest update it keeps misrepresenting even in javascript

this sentence <Screenshot 2024-05-17 at 05.44.51.png>

becomes like this : <Screenshot 2024-05-17 at 05.44.32.png>

and it is pretty inconvenient

1024jp commented 4 months ago

Sorry that I couldn't fit the original issue in the last versions. I was more complicated than I initially thought. I'll find a solution further, but now I feel it is hard to fix it with the current implementation of syntax highlighting. Let me have a time.