search

cotes2020 / jekyll-theme-chirpy

A minimal, responsive, and feature-rich Jekyll theme for technical writing.
https://chirpy.cotes.page
MIT License
7.18k stars 5.67k forks source link

Pageviews regression in 6.5.2 gem #1581

Closed steveng57 closed 6 months ago

steveng57 commented 6 months ago

Checklist

How did you create the site?

Generated from chirpy-starter

Describe the bug

It seems that the post.html layout in the 6.5.2 gem does not have the pageviews code in it. It looks fine in 6.5.1.

If you download the 6.5.1 gem, you can see it in post.html around line 77. It is not there in the downloaded 6.5.2 gem.

It looks fine on github.

This means that it will work if you are on version 6.5.1 from the chirpy starter, and it will work if you are working from a fork. If you are working with the 6.5.2 gem from the chirpy starter, then it will not work.

It also means that the goatcounter stats are not being updated, as the javascript selector looks like it is missing the pageviews bits too.

Steps To Reproduce

  1. from the starter kit, work with 6.5.1
  2. enable all goatcounter settings in _config.yml
  3. verify that it works.
  4. upgrade to 6.5.2
  5. verify that pageviews no longer work

Expected Behavior

Pageviews on goatcounter should be updating. Pageviews displays should be shown on post layouts.

Environment

Chirpy 6.5.2 from chirpy starter

Anything else?

No response

kungfux commented 6 months ago

Sorry for the misunderstanding. Pageviews on goatcounter #1543 was not planned to be released as part of the v6.5.1. This feature was not merged into the production branch, and it is not mentioned in the release notes for v.6.5.1. This was done by accident.

According to the release plan, it is planned for next major release.

steveng57 commented 6 months ago

I see. I'll close it out then.