search

cotestatnt / async-esp-fs-webserver

ESP32/ESP8266 WebServer, WiFi manager and ACE web editor Arduino library. Based on ESPAsyncWebServer
Apache License 2.0
33 stars 10 forks source link

on setup page, fix missing save icon on Update tab, save configuration button, #20

Closed rob040 closed 5 months ago

rob040 commented 5 months ago

On setup page, fix missing save icon on Update tab, save configuration button, and align "Store wifi credentials" switch to left and look same as other input fields.

app.js: duplicate svg-save ref to svg-save2, hide save button when no-dhcp is disabled; other deltas are white space/tabs setup.htm: duplicate svg-save ref to svg-save2,

see also issue #19

cotestatnt commented 5 months ago

Hi @rob040 The appearance of the checkbox in question was deliberately left different to give it a different visibility and also because with the right alignment the page seems more "harmonious" according to my aesthetic taste. In any case, I take the proposal into consideration and we will evaluate it.

As for the button, you need to leave it visible because if the no-dhcp option was active and you want to disable, you still need to save. Hiding the button can give the user the impression that it is not necessary and leave it on true in the /config.json file.

For the missing icon, something went wrong with the latest updates made to the page. The button you see is the same one that is simply moved to the box where it is needed and therefore it should not be necessary to duplicate it.

I would like to check better what I've done before, because in theory it shouldn't happen.

cotestatnt commented 5 months ago

The button you see is the same one that is simply moved to the box

I wrote something incorrect, sorry. This was my first intention, but then it turned out to be easier to duplicate the button