search

coti-io / coti-node

COTI is the first DAG based chain protocol that's optimized for Enterprises and Stable-coins.
https://coti.io
GNU General Public License v3.0
188 stars 23 forks source link

javafx on JDK 12 fails #2

Closed carlos-verdes closed 2 years ago

carlos-verdes commented 4 years ago

I tried to run your first command and failed:

mvn initialize && mvn clean compile && mvn package -DskipTests

I read and is caused by javafx being out of Java SDK on last versions (and your build depends on version 8).

I patched the pom of the two projects that were failing adding a dependency to openfx, I'll create a pull request just in case is useful for the project.

Added version on properties:

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        <java.version>1.8</java.version>
        <javafx.version>15-ea+1</javafx.version>
    </properties>

And the dependency where needed:

        <dependency>
            <groupId>org.openjfx</groupId>
            <artifactId>javafx-controls</artifactId>
            <version>${javafx.version}</version>
        </dependency>