search

coto / gae-boilerplate

Google App Engine Boilerplate
https://dev-dot-sandengine.appspot.com/
Other
684 stars 187 forks source link

try except block in check_login catches too many errors #188

Open peta15 opened 12 years ago

peta15 commented 12 years ago

https://github.com/coto/gae-boilerplate/blob/master/boilerplate/lib/basehandler.py#L38-42

This try except block in basehandler.py check_login is meant to "avoid AttributeError when the session was delete from the server" but it catches all AttributeErrors which means some errors are suppressed when they should not be. There should be a check in the except block to see if session is deleted and if not raise the error again so that it is not artifically suppressed.

snvandoorn commented 11 years ago

Fixing this, would probably also fix or at least make the issue of #247 transparent.