search

coto / gae-boilerplate

Google App Engine Boilerplate
https://dev-dot-sandengine.appspot.com/
Other
685 stars 189 forks source link

Is basehandler.current_user() needed? #302

Open movero opened 10 years ago

movero commented 10 years ago

lib/basehandler.py has two methods for getting a user and they are user() and current_user().

I think the latter one is not needed. The latter is only called in basehandler.py get_user_tz(), which I think could just utilize the user() method instead.

Incidentally, get_user_tz() does not seem to be called anywhere, but I'm not suggesting removing it as it could be useful in the future.

movero commented 10 years ago

Hmmm, not sure now. Looking through all the calls to user() it seems like it may be better to switch most of them to current_user().