coto / gae-boilerplate

Google App Engine Boilerplate
https://dev-dot-sandengine.appspot.com/
Other
685 stars 189 forks source link

Updated Google Recaptcha #308

Open chuycepeda opened 9 years ago

chuycepeda commented 9 years ago

Hi !

I've updated the google recaptcha method to the newest, coolest "I'm not a robot" version. Mainly I've changed captcha.py and also the captcha.displayhtml(..) calls.

I've never contributed to a repo like this so (1) perhaps you can help me to push it here or (2) you can pick code from https://github.com/chuycepeda/gae-boilerplate/blob/master/bp_includes/lib/captcha.py and look for captcha.displayhtml() calls to send only public_key argument at handlers.

Cheers,

Chuy

nvictor commented 9 years ago

thanks buddy,

maybe i was mistaken by the "actively developed". i have dealt with the new Google re-captcha and they are already pushing it. good to see someone that is keeping with all this craziness : )

nvictor commented 9 years ago

i have to take my good comment back for posterity : 3 sorry

really semi-colon and weird formatting in Python code ? : )

chuycepeda commented 9 years ago

hahahaha can't tell why it works like charm on the appengine....

I went directly to check why there's the semi-colon and ¡surprise! it is on the production file which is working with no issues, interesting to notice...could the appengine override this typical issues?

I've already removed it, thanks for noticing it !

coto commented 9 years ago

Hi @chuycepeda Thanks... could you try to send a pull request with that please?