search

cott-io / iron-cli-releases-repo

Project Iron (Fe) release artifacts and installation utilities
0 stars 0 forks source link

Evaluate new readline implementations #12

Closed pkopriv2 closed 5 years ago

pkopriv2 commented 5 years ago

Our current readline implementation is very spotty across environments. Many users are experiencing output similar to this:

image

We should evaluate other readline implementations or other "prompt" alternatives and estimate the work effort to replace.

AC:

zenorseman commented 5 years ago

Same results for in terminator, and Ubuntu terminal Default shell is bash - 4.4.19 ubuntu_terminal bashversion ubuntu_terminator

zenorseman commented 5 years ago

Guake doesnt seem to have that issue ubuntu_guake

zenorseman commented 5 years ago

This issue is multiplatform - It is present on Arch, Gentoo, Fedora, openSUSE, Mint, and Ubuntu with KDE, Mate, Cinnamon, and Gnome installed using the pre-installed and configured Terminal programs for the reapective distributions. If you install guake on these same systems the issue isn't present on guake but it does exist in LXTerminal, Gnome Terminal, Konsole, Mate Terminal, xTerm, and Terminator on these platforms.

pkopriv2 commented 5 years ago

It sounds to me like it's prevalent enough that we should probably do something about it. I think we should definitely accept this issue and begin researching alternative implementations.

pkopriv2 commented 5 years ago

We have begun working on this issue. We ended up swapping out the readline implementation with https://github.com/c-bata/go-prompt. We also evaluated promptui - but it had no facilities for injecting auto completions. That being said, go-prompt's api is slightly lacking and does a poor job of defining consistent behavior on signal handling (ie ctrl-c does not exit the prompt but produces a new line). For the time being we're going to fork the implementation and amend it, with a plan to contribute the changes upstream.

benhammes commented 5 years ago

SPIKE: Moving to database approach.

benhammes commented 5 years ago

Circular buffer implemented with files.

benhammes commented 5 years ago

File implementation is more efficient than database.

benhammes commented 5 years ago

Get update from Manohar and Aadarsh.

benhammes commented 5 years ago

Still working on it. Working out bugs.

benhammes commented 5 years ago

Integrating with Tether now.

benhammes commented 5 years ago

Done it, but sure it is done wrong.

benhammes commented 5 years ago

Added to Trello.