search

cott-io / iron-cli-releases-repo

Project Iron (Fe) release artifacts and installation utilities
0 stars 0 forks source link

Dropping nonexistent anchor tag doesn't raise an error #14

Closed thedatabuddy closed 5 years ago

thedatabuddy commented 6 years ago

While in an anchor, dropping a tag that doesn't exist in its list of tags doesn't throw an error. A simple is returned as output.

dropnonexistingtag

pkopriv2 commented 6 years ago

Yup, this breaks the principle of least surprise. We've got a couple options:

  1. Return an error
  2. Print a better message

@ManoharBoorlu What do you think?

manoharboorlu commented 6 years ago

I think printing a better message in different color would be much more understanding to the User compared to returning an error.

thedatabuddy commented 6 years ago

The same happens while adding a tag that already exists. I guess it would be good if an alert is raised instead of an error, just like Manohar said.

benhammes commented 5 years ago

Follow up with Josiah.

josiahconely commented 5 years ago

I have that fixed I need to commit

On Thu, Aug 23, 2018 at 10:31 AM benhammes notifications@github.com wrote:

Follow up with Josiah.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cott-io/iron-releases/issues/14#issuecomment-415460266, or mute the thread https://github.com/notifications/unsubscribe-auth/APbDyeBvd3HpwWLTvxba9w7oh2zYnVF1ks5uTsq3gaJpZM4Vg1Uc .

benhammes commented 5 years ago

Merged into issue 12