search

cottonTracks / extension

1 stars 0 forks source link

install is blocked #101

Open ct-pink opened 11 years ago

ct-pink commented 11 years ago

Juan, one of Red's friends, reported the install never completing. (non lightening button of death...). v0.6.0

Error in response to history.search: TypeError: Cannot call method 'split' of undefined at Class.extend.get (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:1:762) at Class.y.$a.Class.extend.Cc (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:4:448) at Class.extend.Ta (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:3:275) at Class.extend.init (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:1:920) at new Class (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/lib/class.js:49:19) at Class. (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:77:463) at Class. (chrome-extension://flmfagndkngjknjjcoejaihmibcfcjdh/background.min.js:39:663) sendRequest:26 safeCallbackApplysendRequest:26 handleResponsesendRequest:76

The classic "cannot call method 'split' of undefined" is usually from the UrlParser. Weird thing is that it was coming from decodeURIComponent, that we now try catch. So it shouldn't occur anymore. all we know is that it happens in temp_database populate.js method, in the chrome.history.get callback function.

ct-pink commented 11 years ago

I am setting a meeting with Juan to debug it on his computer.

ct-pink commented 11 years ago

the problem was that he had an "about:blank" page in his history. The UrlParser tries to do stuff on the parts after the // on the url, but here it doesn't exist, so it failed and blocked the install. fixed in fc9b20adababf040556d83b0a73ef9dab8cea4f9