search

couchbase / CouchbaseMock

A Java mock for Couchbase
Apache License 2.0
64 stars 42 forks source link

Update maven plugins and Relocate shaded dependencies #45

Closed Aloren closed 5 years ago

Aloren commented 5 years ago

Update maven plugins:

Relocate shaded dependencies into couchbase.mock package

@avsej Please review. I've found your commit with revert of plugins update, but I could not find out what was the issue with the change.

cb-sdk-robot commented 5 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

Your changes (commit: ff2186e1725add518bc3eb295dc4a479a39857c2) have been pushed to the Couchbase Review Site: http://review.couchbase.org/102748

::SDKBOT/PR:created

avsej commented 5 years ago

Thanks @Aloren. I left review comments on gerrit. To update commit there you can do something like:

git remote add gerrit ssh://YOURGERRITNAME@review.couchbase.org:29418/CouchbaseMock
git fetch gerrit refs/changes/48/102748/2 && git checkout FETCH_HEAD

then make fixes, amend top commit and upload for review

git add .
git commit --amend
git push gerrit HEAD:refs/for/master
cb-sdk-robot commented 5 years ago

Your changes (commit: 9bb30f0f5fb9dfeadd956bfffad920ab6788e5ee) have been pushed to the Couchbase Review Site: http://review.couchbase.org/102748

::SDKBOT/PR:updated

Aloren commented 5 years ago

@avsej looks like @cb-sdk-robot does that job better than me :D

Aloren commented 5 years ago

@avsej should i check something specific since all maven plugins were updated?

cb-sdk-robot commented 5 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged

avsej commented 5 years ago

thank you, @Aloren