search

couchbase / CouchbaseMock

A Java mock for Couchbase
Apache License 2.0
64 stars 42 forks source link

Change the registration of the query server to not require a "/" #57

Closed randomanderson closed 5 years ago

randomanderson commented 5 years ago

Reopening because there was an issue with the contributor agreement (bot said I didn't sign when I did)

This pull request resolves #55, #54, and #35 . Essentially, some versions of the Couchbase sdk send query requests to the /query endpoint and not /query/

cb-sdk-robot commented 5 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: lapl*******rson@data*****.com

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

cb-sdk-robot commented 5 years ago

Your changes (commit: b8eb024dc84e6dc913411d3c1eaa80571c64d40c) have been pushed to the Couchbase Review Site: http://review.couchbase.org/112286

::SDKBOT/PR:created

randomanderson commented 5 years ago

Anyone looking at this? It's just a 1 character change.

cb-sdk-robot commented 5 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged