search

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)
https://www.couchbase.com/
Apache License 2.0
243 stars 110 forks source link

Slight tweak to documentation about default lockmode #25

Closed mdengler closed 9 years ago

mdengler commented 10 years ago

When documentation HTML is generated, there is some ambiguity about to which section the italicised "This is the default lockmode" applies: the text appears at the end of the LOCKMODE_EXC section and immediately before LOCKMODE_WAIT, with no visible separators except an empty line.

The default LOCKMODE_EXC section already begins with exactly the same statement. This change removes the trailing redundant and confusingly-located statement and puts the italics on the original, unambiguously-located statement.

mdengler commented 10 years ago

Let me know if this doesn't seem useful.

brett19 commented 9 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit, accept our CLA and push your change there. More detailed instructions are available here: https://developer.couchbase.com/open-source-projects#how-to-contribute-code.

P.S. Our bot tells us you are currently unregistered on Gerrit.

mnunberg commented 8 years ago

http://review.couchbase.org/62961