bugfix: correct way to remove prefix

couchbase / couchbase-python-client

Couchbase Python Client Library (Official)

https://www.couchbase.com/

Apache License 2.0

243 stars 110 forks source link

bugfix: correct way to remove prefix #42

Closed iutinvg closed 3 years ago

iutinvg commented 4 years ago

DesignDocumentNamespace.unprefix("dorking") will return orking which is wrong.

Workaround:

ddname = "dorking"
design_doc = DesignDocument(ddname, views)
# workaround for bug: DesignDocumentNamespace.unprefix
design_doc._name = ddname

cb-sdk-robot commented 4 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

Your changes (commit: ec88a41ed560a69583591eefb1189c618e8759cb) have been pushed to the Couchbase Review Site: http://review.couchbase.org/140774

::SDKBOT/PR:created

ingenthr commented 3 years ago

Thanks for the contribution @iutinvg ! We'll have a look here shortly.

ingenthr commented 3 years ago

This should be in our release on Jan 12, track the JIRA for details! https://issues.couchbase.com/browse/PYCBC-1078

cb-sdk-robot commented 3 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged