Same named tests covering up mismatched exception test on no id found.

couchbase / couchbase-ruby-model

The Active Model implementation for Couchbase Server built on couchbase-ruby-client

61 stars 23 forks source link

Same named tests covering up mismatched exception test on no id found. #3

Closed mje113 closed 11 years ago

mje113 commented 11 years ago

Not really sure if Couchbase::Model's Couchbase::Error::MissingId or the Couchbase gem's Couchbase::Error::NotFound exception should actually be raised here. Changed it to NotFound in the test so it would pass.

avsej commented 11 years ago

I have fixed this issue in http://review.couchbase.org/24684, but could you extract the changes about logging into the separate commit and upload to out review system?

We have a document about how to make a contribution https://github.com/couchbase/couchbase-ruby-model/blob/master/CONTRIBUTING.markdown

avsej commented 11 years ago

@ingenthr I think this ticket might be closed, because original issue has been fixed

mje113 commented 11 years ago

I should have closed this a while ago...