couchbase / docker

Dockerfiles and configuration scripts for the Docker Hub Official Couchbase images
142 stars 154 forks source link

updating exec command #190

Closed patilk234 closed 1 year ago

patilk234 commented 1 year ago

After updating to ubuntu:20.04 this was throwing error "/entrypoint.sh: line 56: /usr/sbin/runsvdir-start: No such file or directory" so correcting it. It is still working on ubuntu:16.04 but after using 20.04 as a base image this entrypoint command needs to be updated

patilk234 commented 1 year ago

@ceejatec Could please let me know who can approve and merge this?

ceejatec commented 1 year ago

The Dockerfile is already based on ubuntu:20.04 ... I just tried rebuilding this exact directory, and the resulting container starts up fine for me. Note lines 27-29 of the Dockerfile create the file /usr/sbin/runsvdir-start.

In any case, we wouldn't want to take a change to one of these Dockerfiles directly, since they are generated files. If there was a bug in them, we'd want to update the generator and template files under the "generate/" top-level directory to ensure the fix was in all appropriate image versions.