search

couchbase / docker

Dockerfiles and configuration scripts for the Docker Hub Official Couchbase images
143 stars 154 forks source link

CBG-3819 declare log file directory to be a volume #212

Closed torcolvin closed 5 months ago

torcolvin commented 5 months ago

Sync gateway writes files to this location, so this should be a volume instead of writing into the container.

bbrks commented 5 months ago

I could be wrong but I think you need to run the script to regenerate the Dockerfiles from the new template.

Same would also be needed for the centos Dockerfile template presumably?

ceejatec commented 5 months ago

We wouldn't normally re-create all extant Dockerfiles when the template is changed, and there's nothing that would cause the images to get re-generated with the newer Dockerfiles even if we did.

torcolvin commented 5 months ago

We wouldn't normally re-create all extant Dockerfiles when the template is changed, and there's nothing that would cause the images to get re-generated with the newer Dockerfiles even if we did.

This is a nice to have fix about documentation more or less, so I don't think it would need to be in older versions.