search

couchbase / docker

Dockerfiles and configuration scripts for the Docker Hub Official Couchbase images
143 stars 154 forks source link

CBD-5970 support building couchbase-columnar docker image. #214

Closed mhocouchbase closed 3 months ago

mhocouchbase commented 3 months ago

add template for generating couchbase-columnar docker images.

-Ming

mhocouchbase commented 3 months ago

Do you think the intent is that couchbase-columnar and couchbase-server Dockerfiles will always be 'identical'? If not, then I think we should take this opportunity to clean up a few things in columnar's Dockerfile.template that are unnecessary / undesirable.

I am not sure how different they will be in the future. Currently, the only difference is ns_server's config profile and deb package itself. Any suggestion on what should be cleaned up?

ceejatec commented 3 months ago

Three things jump out that should be irrelevant for couchbase-columnar:

  1. The comment around .SYSTEMD_WORKAROUND.
  2. The curl.real check.
  3. Probably a bunch of those ports don't need to be exposed for columnar.

Still, from what I hear, for now at least this Docker image is just intended for internal use and debugging, so those are minor points. I'll file a separate ticket for some cleanups and another one for the Ubuntu base image fix, and approve this change.

mhocouchbase commented 3 months ago

Three things jump out that should be irrelevant for couchbase-columnar:

  1. The comment around .SYSTEMD_WORKAROUND.
  2. The curl.real check.
  3. Probably a bunch of those ports don't need to be exposed for columnar.

Still, from what I hear, for now at least this Docker image is just intended for internal use and debugging, so those are minor points. I'll file a separate ticket for some cleanups and another one for the Ubuntu base image fix, and approve this change.

Cool. I made one change to let columnar use ubuntu:24.04. I started working on the base image version fix. Will verify all the dockerfiles before proposing a PR. Please let me know if you have already filed a ticket. I can use it for the PR.