couchbase / forestdb

A Fast Key-Value Storage Engine Based on Hierarchical B+-Tree Trie
Apache License 2.0
1.29k stars 172 forks source link

Fix bugs on superblock.cc for O_DIRECT #10

Closed wurikiji closed 7 years ago

wurikiji commented 8 years ago

For users using O_DIRECT flag, superblock also should call pread/pwrite with aligned memory.

snej commented 8 years ago

Thanks for the patch! If this is your first code contribution to Couchbase, you'll need to fill out our Contributor License Agreement, which basically just declares that you created the code and are allowing us to release it under the Apache license.

wurikiji commented 8 years ago

Thank you for guiding me. I've filled out CLA with my name, 'Gihwan Oh'.

hisundar commented 7 years ago

Changes were merged into master branch as part of another bug fix, so closing this PR